Skip to content

api,engine/schema,server: vm readonly details rename#4671

Merged
yadvr merged 3 commits intoapache:masterfrom
shapeblue:fix-vm-readonlydetails-rename
Apr 9, 2021
Merged

api,engine/schema,server: vm readonly details rename#4671
yadvr merged 3 commits intoapache:masterfrom
shapeblue:fix-vm-readonlydetails-rename

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Feb 9, 2021 •
edited
Loading

Description

Rename global configuration - user.vm.readonly.ui.details to user.vm.readonly.details

Documentation PR: apache/cloudstack-documentation#206

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@shwstppr
api,engine/schema,server: vm readonly details rename
16253fd 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr added this to the 4.16.0.0 milestone Feb 9, 2021
@shwstppr
ui: update api response key
f4686c4 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Feb 9, 2021

@weizhouapache setting name changed here

#4629 (comment)

@shwstppr
Copy link
Contributor Author

shwstppr commented Feb 9, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Feb 9, 2021

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Feb 9, 2021

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2662

@shwstppr
Merge branch 'master' into fix-vm-readonlydetails-rename
66f24ee 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Feb 18, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Feb 18, 2021

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Feb 18, 2021

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2731

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Feb 18, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Feb 18, 2021

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Feb 18, 2021

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2739

@shwstppr
Copy link
Contributor Author

shwstppr commented Feb 18, 2021

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Feb 18, 2021

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Feb 19, 2021

Trillian test result (tid-3575)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31125 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4671-t3575-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

yadvr
yadvr approved these changes Mar 6, 2021
View reviewed changes
Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you need to check and update the docs as well @shwstppr

@yadvr
Copy link
Member

yadvr commented Apr 5, 2021

Is this ready for review/merging @shwstppr ?

@shwstppr
Copy link
Contributor Author

shwstppr commented Apr 5, 2021

@rhtyd I need to create doc PR. I'll update once done.

@shwstppr shwstppr mentioned this pull request Apr 8, 2021
Merged
@shwstppr
Copy link
Contributor Author

shwstppr commented Apr 8, 2021

@blueorangutan package

@shwstppr shwstppr marked this pull request as ready for review April 8, 2021 06:26
@blueorangutan
Copy link

blueorangutan commented Apr 8, 2021

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Apr 8, 2021

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 359

DaanHoogland
DaanHoogland approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@yadvr yadvr merged commit 6d0d701 into apache:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

@davidjumani davidjumani Awaiting requested review from davidjumani

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees

No one assigned

Labels

type:enhancement type:new-feature

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@shwstppr @blueorangutan @DaanHoogland @yadvr @nvazquez